Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested.

On 2021-03-17 08:25, Zhihong Yu wrote:
> Hi,

Thanks for your comments!

> + * Simple signal handler for processes HAVE NOT yet touched or DO NOT
>
> I think there should be a 'which' between processes and HAVE. It seems
> the words in Capital letters should be in lower case.
>
> + * Simple signal handler for processes have touched shared memory to
> + * exit quickly.
>
> Add 'which' between processes and have.

OK, I fixed them.

> unlink(fname);
> +
> + elog(DEBUG2, "removing stats file \"%s\"", fname);
>
> It seems the return value from unlink should be checked and reflected
> in the debug message.

There are related codes that show log and call unlink() in slru.c and
pgstat.c.

```
pgstat_write_db_statsfile(PgStat_StatDBEntry *dbentry, bool permanent)
{
// some code
elog(DEBUG2, "removing temporary stats file \"%s\"", statfile);
unlink(statfile)
}
```

I fixed it in the same way instead of checking the return value because
IIUC, it's unimportant if an error has occurred. The log shows that just
to try
removing it. Though?

Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION