From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | safer node casting |
Date: | 2016-12-31 17:08:22 |
Message-ID: | c5d387d9-3440-f5e0-f9d4-71d53b9fbe52@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
There is a common coding pattern that goes like this:
RestrictInfo *rinfo = (RestrictInfo *) lfirst(lc);
Assert(IsA(rinfo, RestrictInfo));
(Arguably, the Assert should come before the cast, but I guess it's done
this way out of convenience.)
(Not to mention the other common coding pattern of just doing the cast
and hoping for the best.)
I propose a macro castNode() that combines the assertion and the cast,
so this would become
RestrictInfo *rinfo = castNode(RestrictInfo, lfirst(lc));
This is inspired by the dynamic_cast operator in C++, but follows the
syntax of the well-known makeNode() macro.
Besides saving a bunch of code and making things safer, the function
syntax also makes some code easier to read by saving levels of
parentheses, for example:
- Assert(IsA(sstate->testexpr, BoolExprState));
- oplist = ((BoolExprState *) sstate->testexpr)->args;
+ oplist = castNode(BoolExprState, sstate->testexpr)->args;
Attached is a patch that shows how this would work. There is a lot more
that can be done, but I just stopped after a while for now.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Add-castNode-macro.patch | text/x-patch | 33.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2016-12-31 17:11:55 | Re: proposal: session server side variables |
Previous Message | Tom Lane | 2016-12-31 16:56:01 | Re: cast result of copyNode() |