| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Jacob Champion <jchampion(at)timescale(dot)com> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "rjuju123(at)gmail(dot)com" <rjuju123(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de> |
| Subject: | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Date: | 2022-08-23 08:53:14 |
| Message-ID: | c4800477-c877-25ab-3ba8-ab53a1510831@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 8/23/22 4:25 AM, Michael Paquier wrote:
> On Mon, Aug 22, 2022 at 08:10:10AM -0700, Jacob Champion wrote:
>> otherwise I'll sit tight.
> So am I. I have done an extra round of checks around the
> serialization/deserialization logic where I put some elog()'s to look
> at the output passed down with some workers and a couple of auth
> methods, and after an indentation and some comment polishing I finish
> with the attached.
>
> There was one thing that annoyed me with the patch, though, as of the
> lack of initialization of MyClientConnectionInfo at backend startup,
> as we may finish by not calling set_authn() to fill in some of its
> data, so I have placed an extra memset(0) in InitProcessGlobals()
Fair point.
> (note that Port does a calloc() much earlier than that, but I think
> that we don't really want to do more in such code paths, especially
> for the parallelized client information).
>
> I have written a commit message, while on it. Does that look fine to
> you?
Thanks!
That sounds all good to me, except a typo for the author in the commit
message: s/Jocob/Jacob/
Regards,
--
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-08-23 09:03:52 | Re: Reducing the chunk header sizes on all memory context types |
| Previous Message | kuroda.hayato@fujitsu.com | 2022-08-23 08:40:36 | RE: Perform streaming logical transactions by background workers and parallel apply |