Re: [RFC] Removing "magic" oids

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RFC] Removing "magic" oids
Date: 2018-11-22 04:32:07
Message-ID: c422a08f-720d-925c-e9d7-63432e668a38@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11/21/18 7:14 PM, Andres Freund wrote:
> Could you check whether you
> still encounter the issue after applying the attached fix?
>

This has largely fixed the problem, so I think this should be applied.
With some adjustments to the tests to remove problematic cases (e.g.
postgres_fdw's ft_pg_type) the tests pass. The exception is HEAD->HEAD.
The change is that the LOs are not dumped in the same order pre and post
upgrade. I can change the tests to allow for a greater fuzz factor -
generally when the source and target are the same we don't allow any
fuzz. Or if we care we could do a better job of dumping LOs in a
consistent order.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-22 05:29:44 Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
Previous Message Michael Paquier 2018-11-22 04:26:38 Re: Speeding up INSERTs and UPDATEs to partitioned tables