| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Runtime Partition Pruning |
| Date: | 2018-03-01 18:17:24 |
| Message-ID: | c3eb3284-24c8-eff0-f930-a33984d1168a@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi David,
On 03/01/2018 08:04 AM, David Rowley wrote:
> I've also split the patch out a bit more into logical parts in the
> hope it makes things easier to review.
>
A small typo in 0001:
+ * leftmost_ons_pos[x] gives the bit number (0-7) of the leftmost one
bit in a
..."_one_"...
0004 fails "make check-world" due to
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 670; 1259 49954 TABLE
boolp_f jpedersen
pg_restore: [archiver (db)] could not execute query: ERROR: syntax
error at or near "false"
LINE 24: ..." ATTACH PARTITION "public"."boolp_f" FOR VALUES IN (false);
Do you require https://commitfest.postgresql.org/17/1410/ as well ?
I'll look more at 0002-0005 over the coming days.
Thanks for working on this !
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-03-01 18:25:24 | Re: pgbench - test whether a variable exists |
| Previous Message | Andres Freund | 2018-03-01 18:13:40 | Re: [PATCH] Find additional connection service files in pg_service.conf.d directory |