Re: [PATCH] (Windows) psql echoes password when reading from pipe

From: Matthew Stickney <mtstickney(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] (Windows) psql echoes password when reading from pipe
Date: 2018-05-23 19:29:29
Message-ID: c3d315f2-c1dc-18ce-29fa-7919dace540e@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The attached is a patch that uses the _fileno/_get_osfhandle approach.
This doesn't address the stdin fallback, or error handling if opening
termin fails; however, it should be no worse than what's there now, and
it fixes the immediate problem.

I'm still thinking about the fallback in terms of a mintty-type
environment, but I wanted to get this patch out there in the meantime.

-Matt Stickney

Attachment Content-Type Size
0002-Disable-input-echo-on-the-console-not-stdin.patch text/plain 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Paolo Crosato 2018-05-23 19:55:55 Re: Error on vacuum: xmin before relfrozenxid
Previous Message Tom Lane 2018-05-23 19:18:28 Re: printf format selection vs. reality