Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Jacob Champion <jchampion(at)timescale(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, thomas(at)habets(dot)se, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jelte Fennema <postgres(at)jeltef(dot)nl>
Subject: Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert
Date: 2023-04-12 07:11:41
Message-ID: c39be3c5-c1a5-1e33-1024-16f527e251a4@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.04.23 23:29, Jacob Champion wrote:
> On Wed, Apr 5, 2023 at 2:27 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> I squashed and pushed v10 with a few small comment tweaks for typos and some
>> pgindenting. Thanks!
>
> Thank you very much!

This patch (8eda731465) makes the ssl tests fail for me:

not ok 121 - sslrootcert=system does not connect with private CA: matches

# Failed test 'sslrootcert=system does not connect with private CA:
matches'
# at t/001_ssltests.pl line 479.
# 'psql: error: connection to server at "127.0.0.1",
port 53971 failed: SSL SYSCALL error: Undefined error: 0'
# doesn't match '(?^:SSL error: certificate verify failed)'

This is with OpenSSL 3.1.0 from macOS/Homebrew.

If I instead use OpenSSL 1.1.1t, then the tests pass.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-04-12 07:19:49 Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert
Previous Message Richard Guo 2023-04-12 06:01:37 Re: v12: ERROR: subplan "InitPlan 2 (returns $4)" was not initialized