| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Reject ENCODING option for COPY TO FORMAT JSON |
| Date: | 2026-05-30 13:20:16 |
| Message-ID: | c347fbce-ff41-40af-bcd5-47fbd6cfd04f@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-05-04 Mo 10:43 AM, Ayush Tiwari wrote:
> Hi,
>
> On Mon, 4 May 2026 at 19:49, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> Basically good, I think. I have modified your test a bit, testing
> more directly for the presence of the LATIN-1 encoded character
> and the absence of the UTF-8 encoded character, by reading in the
> file with pg_read_binary_file, and adding a test for implicit
> encoding by setting client_encoding.
>
>
> The revised tests look better to me. Checking the raw bytes with
> pg_read_binary_file() directly verifies that LATIN1 output does not
> contain
> the UTF-8 sequence, and the added implicit client_encoding case too
> looks good.
>
> Thanks for improving the test coverage.
>
>
pushed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-05-30 13:21:21 | Re: Avoid leaking system path from pg_available_extensions |
| Previous Message | Ilmar Y | 2026-05-30 12:14:33 | Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement |