| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Vaibhav Dalvi <vaibhav(dot)dalvi(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression |
| Date: | 2023-11-15 11:39:30 |
| Message-ID: | c32bd257-2b65-4363-b685-0f7c40d20afe@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.11.23 11:40, Amul Sul wrote:
> Please have a look at the attached version, updating the syntax to have "AS"
> after EXPRESSION and other changes suggested previously.
The code structure looks good to me now.
Question: Why are you using AT_PASS_ADD_OTHERCONSTR? I don't know if
it's right or wrong, but if you have a specific reason, it would be good
to know.
I think ATExecSetExpression() needs to lock pg_attribute? Did you lose
that during the refactoring?
Tiny comment: The error message in ATExecSetExpression() does not need
to mention "stored", since it would be also applicable to virtual
generated columns in the future.
Documentation additions in alter_table.sgml should use one-space indent
consistently. Also, "This form replaces expression" is missing a "the"?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2023-11-15 11:44:09 | Re: BUG #18097: Immutable expression not allowed in generated at |
| Previous Message | Dean Rasheed | 2023-11-15 11:36:59 | Re: MERGE ... RETURNING |