Re: Add support for DEFAULT specification in COPY FROM

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>, Israel Barth Rubio <barthisrael(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add support for DEFAULT specification in COPY FROM
Date: 2023-03-15 21:21:49
Message-ID: c3185ca1-ff67-ef0d-6557-bc8de8790e81@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-03-15 We 13:00, Alexander Lakhin wrote:
> Hello,
> 13.03.2023 17:15, Andrew Dunstan wrote:
>>
>> On 2022-12-02 Fr 09:11, Israel Barth Rubio wrote:
>>> Hello all,
>>>
>>> I'm submitting a new version of the patch. Instead of changing
>>> signature
>>> of several functions in order to use the defaults parameter, it is
>>> now storing
>>> that in the cstate structure, which is already passed to all
>>> functions that
>>> were previously modified.
>>>
>>
>> Thanks, committed.
>
> Please look at the query:
> create table t (f1 int);
> copy t from stdin with (format csv, default '\D');
> 1,\D
>
> that invokes an assertion failure after 9f8377f7a:
> Core was generated by `postgres: law regression [local]
> COPY                                         '.
> Program terminated with signal SIGABRT, Aborted.
>
>

Fix pushed, thanks for the report.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-03-15 21:38:37 Memory leak in libxml2 (was Re: [PATCH] Add pretty-printed XML output option)
Previous Message Thomas Munro 2023-03-15 21:13:56 Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED