Re: Building with musl in CI and the build farm

From: Wolfgang Walther <walther(at)technowledgy(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Building with musl in CI and the build farm
Date: 2024-04-04 14:11:56
Message-ID: c2e81ddf-747a-420f-ab7f-1c545c8bc59c@technowledgy.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Peter Eisentraut:
> On 31.03.24 15:34, walther(at)technowledgy(dot)de wrote:
>>> I'd rather adapt one of the existing tasks, to avoid increasing CI
>>> costs unduly.
>>
>> I looked into this and I think the only task that could be changed is
>> the SanityCheck.
>
> I think SanityCheck should run a simple, "average" environment, like the
> current Debian one.  Otherwise, niche problems with musl or multi-arch
> or whatever will throw off the entire build pipeline.

All the errors/problems I have seen so far, while setting up the
buildfarm animal on Alpine Linux, have been way beyond what SanityCheck
does. Problems only appeared in the tests suites, of which sanity check
only runs *very* basic ones. I don't have much experience with the
"cross" setup, that "musl on debian" essentially is, though.

All those things are certainly out of scope for CI - they are tested in
the build farm instead.

I do agree: SanityCheck doesn't feel like the right place to put this.
But on the other side.. if it really fails to *build* with musl, then it
shouldn't make a difference whether you will be notified about that
immediately or later in the CI pipeline. It certainly needs the fewest
additional resources to put it there.

I'm not sure what Andres meant with "adopting one of the existing
tasks". It could fit as another step into the "Linux - Debian Bullseye -
Autoconf" task, too. A bit similar to how the meson task build for 32
and 64bit. This would still not be an entirely new task like I proposed
initially (to run in Docker).

Best,

Wolfgang

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2024-04-04 14:36:41 Re: Building with musl in CI and the build farm
Previous Message Peter Eisentraut 2024-04-04 13:56:25 Re: Building with musl in CI and the build farm

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-04-04 14:26:42 Re: WIP Incremental JSON Parser
Previous Message Peter Eisentraut 2024-04-04 13:56:25 Re: Building with musl in CI and the build farm