From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PROVE_FLAGS |
Date: | 2017-05-16 23:44:49 |
Message-ID: | c26a7416-2fb9-34ab-7991-618c922f896e@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 5/3/17 15:14, Andrew Dunstan wrote:
> Can someone please explain to me why we have this in Makefile.global.in?
> (from commit e9c81b60 )
>
> PROVE_FLAGS =
>
> ISTM it's unnecessary, and prevents us from using the same named value
> in the environment. I want to be able to use the environment in
> vcregress.pl, and I'd like the Make files to work the same way.
I think relying on environment variables like this is a bad design.
Someone could have something left in the environment and it changes
things in mysterious ways. For all other *FLAGS variables, we
explicitly set them in Makefile.global, sometimes to empty values, as
the case may be.
Note that specifying a variable on the make command line overrides
settings in the makefile under certain circumstances, which is a useful
feature.
So I think the above setting was correct, the new behavior is
inconsistent and incorrect, and I think this change should be reverted.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-05-16 23:45:56 | Re: synchronous_commit option is not visible after pressing TAB |
Previous Message | Andrew Dunstan | 2017-05-16 23:40:47 | Re: PG10 pgindent run |