Re: Unify DLSUFFIX on Darwin

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unify DLSUFFIX on Darwin
Date: 2022-07-06 06:08:07
Message-ID: c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.06.22 16:13, Tom Lane wrote:
> [ thinks for a bit... ] Might be worth double-checking that pg_upgrade
> doesn't get confused in a cross-version upgrade. A quick grep doesn't
> find that it refers to DLSUFFIX anywhere, but it definitely does pay
> attention to extensions' shared library names.

pg_upgrade just checks that it can "LOAD" whatever it finds in probin.
So this will work if extensions use the recommended extension-free file
names. If they don't, they should get a clean failure.

If this becomes a problem in practice, we could make pg_dump
automatically adjust the probin on upgrade from an old version.

I have committed this now. We can see how it goes.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-06 06:27:28 Re: Improve TAP tests of pg_upgrade for cross-version tests
Previous Message Amit Kapila 2022-07-06 06:00:51 Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns