| From: | Bryan Green <dbryan(dot)green(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add Windows support for backtrace_functions (MSVC only) |
| Date: | 2025-10-27 17:58:31 |
| Message-ID: | c23d81e2-97c0-4ef4-a8c4-1ada461fbc1f@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/20/2025 3:40 AM, Michael Paquier wrote:
> On Mon, Oct 20, 2025 at 10:10:25AM +0200, Jakub Wartak wrote:
>> Cool, thanks for working on this. Win32 is a bit alien to me, but I've
>> got access to win32 so I've played with the patch a little bit. With
>> simple: SET backtrace_functions = 'typenameType'; CREATE TABLE tab (id
>> invalidtype);
>
> Perhaps it would be possible to add some WIN32-specific tests that
> check some log patterns based on the backtraces printed? (I have not
> read the patch in details, just an idea while passing by.)
> --
> Michael
Michael,
Thanks for even glancing at this. I did not add any regression
tests because the output goes to the server log and not the client.
BG
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-10-27 18:02:13 | Re: COPY WHERE clause generated/system column reference |
| Previous Message | Sami Imseih | 2025-10-27 17:47:15 | Re: another autovacuum scheduling thread |