| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: elog(DEBUG2 in SpinLocked section. |
| Date: | 2020-06-02 10:24:16 |
| Message-ID: | c22c01ca-b128-df91-f7ef-5ec89525fee0@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/06/02 17:42, Amit Kapila wrote:
> On Tue, Jun 2, 2020 at 2:05 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>> On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
>>> Hello.
>>>
>>> I noticed that UpdateSpillStats calls "elog(DEBUG2" within
>>> SpinLockAcquire section on MyWalSnd. The lock doesn't protect rb and
>>> in the first place the rb cannot be modified during the function is
>>> running.
>>>
>>> It should be out of the lock section.
>
> Right.
>
>>
>> Thanks for the patch! It looks good to me.
>>
>
> The patch looks good to me as well. I will push this unless Fujii-San
> wants to do it.
Thanks! I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2020-06-02 10:28:57 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Amit Kapila | 2020-06-02 09:40:41 | Re: Resetting spilled txn statistics in pg_stat_replication |