Re: [PATCH] Add function to_oct

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Kirk Wolak <wolakk(at)gmail(dot)com>, Eric Radman <ericshane(at)eradman(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add function to_oct
Date: 2023-08-22 14:57:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 22.08.23 16:26, Nathan Bossart wrote:
>> I don't understand the reason for this handling of negative values. I would
>> expect that, say, to_hex(-1234) would return '-' || to_hex(1234).
> For this patch set, I was trying to retain the current behavior, which is
> to return the two's complement representation. I'm open to changing this
> if there's agreement on what the output should be.

Ah, if there is existing behavior then we should probably keep it.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-08-22 15:43:29 Re: Oversight in reparameterize_path_by_child leading to executor crash
Previous Message Ashutosh Bapat 2023-08-22 14:53:39 Re: persist logical slots to disk during shutdown checkpoint