Re: row filtering for logical replication

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Suzuki Hironobu <hironobu(at)interdb(dot)jp>
Subject: Re: row filtering for logical replication
Date: 2018-11-02 06:55:05
Message-ID: c1791604db16e94b40ccae60ccaa7a64@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-11-02 02:59, Euler Taveira wrote:
> Em qui, 1 de nov de 2018 às 05:30, Erik Rijkers <er(at)xs4all(dot)nl>
> escreveu:
>> > I ran pgbench-over-logical-replication with a WHERE-clause and could
>> > not get this to do a correct replication. Below is the output of the
>> > attached test program.
>> >
>> >
>> > $ ./logrep_rowfilter.sh
>>
> Erik, thanks for testing.
>
>> So it seems this bug is due to some timing error in your patch (or
>> possibly in logical replication itself).
>>
> It is a bug in the new synchronization code. I'm doing some code
> cleanup/review and will post a new patchset after I finish it. If you
> want to give it a try again, apply the following patch.
>
> diff --git a/src/backend/replication/logical/tablesync.c
> b/src/backend/replication/logical/tablesync.c
> index e0eb73c..4797e0b 100644
> --- a/src/backend/replication/logical/tablesync.c
> +++ b/src/backend/replication/logical/tablesync.c
> [...]

That does indeed fix it.

Thank you,

Erik Rijkers

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2018-11-02 07:16:53 Re: Doubts about pushing LIMIT to MergeAppendPath
Previous Message Pavel Stehule 2018-11-02 05:33:42 Re: COPY FROM WHEN condition