|From:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>|
|To:||Shawn Debnath <clocksweep(at)gmail(dot)com>|
|Cc:||Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>|
|Subject:||Re: SLRUs in the main buffer pool, redux|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 20/01/2023 19:00, Shawn Debnath wrote:
> On Mon, Jul 25, 2022 at 11:54:36AM +0300, Heikki Linnakangas wrote:
>> Oh I just saw that you had a comment about that in the patch and had hacked
>> around it. Anyway, calling ResourceOwnerEnlargeBuffers() might be a
>> solution. Or switch to a separate "CriticalResourceOwner" that's guaranteed
>> to have enough pre-allocated space, before entering the critical section.
> Wanted to bump up this thread. Rishu in my team posted a patch in the other
> SLRU thread  with the latest updates and fixes and looks like performance
> numbers do not show any regression. This change is currently in the
> January commitfest  as well. Any feedback would be appreciated!
Here's a rebased set of patches.
The second patch is failing the pg_upgrade tests. Before I dig into
that, I'd love to get some feedback on this general approach.
|Next Message||Daniel Gustafsson||2023-02-27 13:35:52||Re: Stale references to guc.c in comments/tests|
|Previous Message||Bharath Rupireddy||2023-02-27 13:24:00||Re: Allow logical replication to copy tables in binary format|