| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Remove workarounds to format [u]int64's |
| Date: | 2022-03-23 20:48:48 |
| Message-ID: | c0f67e77-6ba2-c05a-d75a-50ea5a807107@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.03.22 15:37, Aleksander Alekseev wrote:
>> It would not simplify things for them at all, just mess it up.
>> The master copies of the .po files are kept in a different repo.
>> Also, I believe that extraction of new message strings is automated
>> already.
>
> Got it, thanks. Here is the corrected patch. It includes all the
> changes by me and Japin, and doesn't touch PO files.
I think in some cases we can make this even simpler (and cast-free) by
changing the underlying variable to be long long instead of int64.
Especially in cases where the whole point of the variable is to be some
counter that ends up being printed, there isn't a need to use int64 in
the first place. See attached patch for examples.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Change-some-variables-to-long-long-from-int64.patch | text/plain | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-03-23 20:49:09 | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Previous Message | Dmitry Dolgov | 2022-03-23 20:47:47 | Re: MDAM techniques and Index Skip Scan patch |