Re: pg_upgrade failing for 200+ million Large Objects

From: Jan Wieck <jan(at)wi3ck(dot)info>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Robins Tharakan <tharakan(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
Date: 2021-03-23 18:54:29
Message-ID: c0f5fde5-5cad-65ed-dd30-cd852301d074@wi3ck.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/23/21 2:35 PM, Tom Lane wrote:
> Jan Wieck <jan(at)wi3ck(dot)info> writes:
>> So the question remains, how do we name this?
>
>> --pg-dump-options "<string>"
>> --pg-restore-options "<string>"
>
> If you're passing multiple options, that is
>
> --pg-dump-options "--foo=x --bar=y"
>
> it seems just horribly fragile. Lose the double quotes and suddenly
> --bar is a separate option to pg_upgrade itself, not part of the argument
> for the previous option. That's pretty easy to do when passing things
> through shell scripts, too. So it'd likely be safer to write
>
> --pg-dump-option=--foo=x --pg-dump-option=--bar=y
>
> which requires pg_upgrade to allow aggregating multiple options,
> but you'd probably want it to act that way anyway.

... which would be all really easy if pg_upgrade wouldn't be assembling
a shell script string to pass into parallel_exec_prog() by itself.

But I will see what I can do ...

Regards, Jan

--
Jan Wieck
Principle Database Engineer
Amazon Web Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-03-23 18:59:24 Re: pg_upgrade failing for 200+ million Large Objects
Previous Message Andres Freund 2021-03-23 18:51:02 Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested.