Re: Fix help option of contrib/oid2name

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix help option of contrib/oid2name
Date: 2018-08-17 07:03:21
Message-ID: c0ef0523-13f4-1a97-ce86-7ed6b2e38b02@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2018/08/17 12:42, Tatsuro Yamada wrote:
> On 2018/08/17 11:47, Michael Paquier wrote:
>> On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
>>> I agree on both points.  Any objections if I apply what's proposed here
>>> on HEAD?
>>
>> I have been looking at this patch.  And while consistency is nice, I
>> think that if we are cleaning up this stuff we could do a bit more to
>> be more consistent with the other binary tools:
>> - Addition of long options for connection options.
>> - removal of -h, and use it for host value instead of "-H".
>> - Use "USERNAME" instead of "NAME" in help().
>>
>> vacuumlo could also be improved a bit...
>
> Yeah, I'll revise the patch based on your suggestions.

I created WIP patch for oid2name and vacuumlo includes followings:

oid2name and vacuumlo
- Add long options

only oid2name
- Replace -H with -h
- Replace NAME with USERNAME

I'll revise their documents and create new patch next week, probably. :)

Regards,
Tatsuro Yamada

Attachment Content-Type Size
fix_help_option_for_oid2name_vacuumlo_wip1.patch text/x-patch 7.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2018-08-17 07:48:26 Re: Problem with OpenSCG downloads
Previous Message David Rowley 2018-08-17 06:58:23 Re: FailedAssertion on partprune