Re: Fix help option of contrib/oid2name

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix help option of contrib/oid2name
Date: 2018-08-17 03:42:49
Message-ID: a856e18e-515e-d8b2-1acf-c29ce16681a4@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018/08/17 11:47, Michael Paquier wrote:
> On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
>> I agree on both points. Any objections if I apply what's proposed here
>> on HEAD?
>
> I have been looking at this patch. And while consistency is nice, I
> think that if we are cleaning up this stuff we could do a bit more to
> be more consistent with the other binary tools:
> - Addition of long options for connection options.
> - removal of -h, and use it for host value instead of "-H".
> - Use "USERNAME" instead of "NAME" in help().
>
> vacuumlo could also be improved a bit...

Yeah, I'll revise the patch based on your suggestions.

Regards,
Tatsuro Yamada

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Lepikhov 2018-08-17 03:47:15 [PATCH] XLogReadRecord returns pointer to currently read page
Previous Message Tatsuro Yamada 2018-08-17 03:34:47 Re: Fix help option of contrib/oid2name