Re: Yet another fast GiST build

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Yet another fast GiST build
Date: 2021-01-13 08:41:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 12/01/2021 18:19, Andrey Borodin wrote:
>> 12 янв. 2021 г., в 18:49, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
>> написал(а):
>> Fixed the docs accordingly, and ran pgindent. New patch version
>> attached.
> Thanks! Looks good to me.

Pushed, thanks!

> One more question: will bytea tests run correctly on
> 32bit\different-endian systems?

Good question. Somehow I thought we were printing esseantilly text
values as bytea. But they are Points, which consists of float8's. Since
I already pushed this, I'm going to just wait and see what the buildfarm
says, and fix if needed. I think the fix is going to be to just remove
the test for the bytea-variant, it doesn't seem that important to test.

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-01-13 08:44:01 Re: [HACKERS] Custom compression methods
Previous Message Ajin Cherian 2021-01-13 08:33:12 Re: Track replica origin progress for Rollback Prepared