Re: Remove Deprecated Exclusive Backup Mode

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove Deprecated Exclusive Backup Mode
Date: 2020-07-01 08:00:38
Message-ID: beadb5d5272b9297c0766fae0ec54f4b5f846daf.camel@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2020-06-30 at 17:38 -0400, David Steele wrote:
> Rebased patch is attached.

I remain -1 on removing the exclusive backup API.

People who don't mind manual intervention when PostgreSQL doesn't
start after a crash in backup mode could safely use it.

We have been over this, and there is not much point in re-opening
the discussion. I just had to speak up.

> Lastly, there is some concern about getting the backup label too late
> when doing snapshots or using traditional backup software. It would
> certainly be possible to return the backup_label and tablespace_map from
> pg_start_backup() and let the user make the choice about what to do with
> them. Any of these methods will require some scripting so I don't see
> why the files couldn't be written as, for example, backup_label.snap and
> tablespace_map.snap and then renamed by the restore script. The patch
> does not currently make this change, but it could be added pretty easily
> if that overcomes this objection.

That would be interesting improvements that would make the non-exclusive
backup API easier to use.

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-07-01 08:15:34 Re: tar-related code in PostgreSQL
Previous Message Fujii Masao 2020-07-01 07:43:42 Re: Creating a function for exposing memory usage of backend process