| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor dlopen() support |
| Date: | 2018-09-07 16:27:28 |
| Message-ID: | beaac5d2-33e4-0d60-5e7a-72fb034e35a9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 07/09/2018 16:19, Tom Lane wrote:
> Somehow or other, the changes you made in dfmgr.c's #include lines
> have made it so that find_rendezvous_variable's local "bool found"
> variable is actually of type _Bool (which is word-wide on these
> machines). However, hash_search thinks its output variable is
> of type pointer to "typedef char bool". The proximate cause of
> the observed failure is that find_rendezvous_variable sees "found"
> as true when it should not, and thus fails to zero out the variable's
> value.
Ah because dlfcn.h includes stdbool.h. Hmm.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-09-07 18:01:37 | pgsql: Improve handling of corrupted two-phase state files at recovery |
| Previous Message | Tom Lane | 2018-09-07 14:19:06 | Re: pgsql: Refactor dlopen() support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-07 16:56:55 | Re: [PATCH] Fix for infinite signal loop in parallel scan |
| Previous Message | James Coleman | 2018-09-07 16:17:25 | Partial index plan/cardinality costing |