Re: proposal: schema variables

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, DUVAL REMI <REMI(dot)DUVAL(at)cheops(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: proposal: schema variables
Date: 2021-01-08 17:54:55
Message-ID: bdeb7611c6dbf22226c302bcc01d178b@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-01-08 07:20, Pavel Stehule wrote:
> Hi
>
> just rebase
>
> [schema-variables-20200108.patch]

Hey Pavel,

My gcc 8.3.0 compile says:
(on debian 10/Buster)

utility.c: In function ‘CreateCommandTag’:
utility.c:2332:8: warning: this statement may fall through
[-Wimplicit-fallthrough=]
tag = CMDTAG_SELECT;
~~~~^~~~~~~~~~~~~~~
utility.c:2334:3: note: here
case T_LetStmt:
^~~~

compile, check, check-world, runs without further problem.

I also changed a few typos/improvements in the documentation, see
attached.

One thing I wasn't sure of: I have assumed that
ON TRANSACTIONAL END RESET

should be
ON TRANSACTION END RESET

and changed it accordingly, please double-check.

Erik Rijkers

Attachment Content-Type Size
create_variable.sgml.20210108.diff text/x-diff 4.6 KB
discard.sgml.20210108.diff text/x-diff 299 bytes
drop_variable.sgml.20210108.diff text/x-diff 674 bytes
let.sgml.20210108.diff text/x-diff 1.1 KB
plpgsql.sgml.20210108.diff text/x-diff 845 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2021-01-08 18:38:29 Re: WIP: System Versioned Temporal Table
Previous Message Ryan Lambert 2021-01-08 16:50:03 Re: WIP: System Versioned Temporal Table