| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, DUVAL REMI <REMI(dot)DUVAL(at)cheops(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: proposal: schema variables |
| Date: | 2021-01-10 16:54:48 |
| Message-ID: | CAFj8pRCGTjqHvH9oeiSf4T6Bydhk9pm033DxxibgF+B7SHC6MQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
pá 8. 1. 2021 v 18:54 odesílatel Erik Rijkers <er(at)xs4all(dot)nl> napsal:
> On 2021-01-08 07:20, Pavel Stehule wrote:
> > Hi
> >
> > just rebase
> >
> > [schema-variables-20200108.patch]
>
> Hey Pavel,
>
> My gcc 8.3.0 compile says:
> (on debian 10/Buster)
>
> utility.c: In function ‘CreateCommandTag’:
> utility.c:2332:8: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> tag = CMDTAG_SELECT;
> ~~~~^~~~~~~~~~~~~~~
> utility.c:2334:3: note: here
> case T_LetStmt:
> ^~~~
>
yes, there was an error from the last rebase. Fixed
>
> compile, check, check-world, runs without further problem.
>
> I also changed a few typos/improvements in the documentation, see
> attached.
>
> One thing I wasn't sure of: I have assumed that
> ON TRANSACTIONAL END RESET
>
> should be
> ON TRANSACTION END RESET
>
> and changed it accordingly, please double-check.
>
It looks well, I merged these changes to patch. Thank you very much for
these corectures
Updated patch attached
Regards
Pavel
>
> Erik Rijkers
>
| Attachment | Content-Type | Size |
|---|---|---|
| schema-variables-20210110.patch.gz | application/gzip | 65.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-01-10 17:29:45 | Re: [HACKERS] Custom compression methods |
| Previous Message | Vik Fearing | 2021-01-10 15:36:49 | Re: support for MERGE |