Re: psql slash# command

From: "Sibte Abbas" <sibtay(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql slash# command
Date: 2008-04-11 00:56:46
Message-ID: bd6a35510804101756t2023f3b3x8d0b78b536a6ba6e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, Apr 3, 2008 at 7:54 PM, Sibte Abbas <sibtay(at)gmail(dot)com> wrote:

> On Sun, Mar 30, 2008 at 3:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:<http://archives.postgresql.org/pgsql-hackers/2006-12/msg00255.php>
>
>
> > I wonder whether it wouldn't be safer and more convenient if we defined
> > '\# n' as pulling command n into the edit buffer, rather than
> > immediately executing it. Actual execution is only a <return> away,
> > but this definition would allow you to edit the command a bit more
> > before you execute it --- including \e to use an editor. It also
> > closes the loop in terms of providing some confidence that you typed
> > the number you should have typed.
> >
>
> This makes more sense and also appears to be much safer. I will start
> modifying the patch as per this approach now.
>
>
Based on your feedback I have modified the attached patch as follows:

1) \# n opens command n into the edit buffer.

2) A new psql variable; SHOW_LINE_NO is added, which is consulted by the \s
command.
If it is set, \s prefixs each line of its output with an incrementing
line number.

regards,
-- Sibte Abbas

Attachment Content-Type Size
psql_slash#_v3.patch text/x-patch 16.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sibte Abbas 2008-04-11 01:13:57 Re: psql slash# command
Previous Message Robert Treat 2008-04-11 00:43:57 Re: [COMMITTERS] pgsql: Remove mention of the Berkeley origins of the alias "Postgres"

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2008-04-11 11:25:48 Typo in README
Previous Message Andrew Chernow 2008-04-10 19:57:45 Re: [PATCHES] libpq type system 0.9a