| From: | Vik Fearing <vik(at)postgresfriends(dot)org> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: MERGE ... RETURNING |
| Date: | 2023-07-13 16:43:37 |
| Message-ID: | bd4bfdf8-9454-edea-7b59-2d38fb3737b9@postgresfriends.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/13/23 17:38, Dean Rasheed wrote:
> On Tue, 11 Jul 2023 at 21:43, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>>
>>>> I think the name of function pg_merge_when_clause() can be improved.
>>>> How about pg_merge_when_clause_ordinal().
>>>
>>> That's a bit of a mouthful, but I don't have a better idea right now.
>>> I've left the names alone for now, in case something better occurs to
>>> anyone.
>>
>> +1. How do we make sure we don't forget that it needs to be named
>> better. Perhaps a TODO item within the patch will help.
>>
>
> Thinking about that some more, I think the word "number" is more
> familiar to most people than "ordinal". There's the row_number()
> function, for example.
There is also the WITH ORDINALITY and FOR ORDINALITY examples.
So perhaps pg_merge_when_clause_number() would
> be a better name. It's still quite long, but it's the best I can think
> of.
How about pg_merge_match_number() or pg_merge_ordinality()?
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-07-13 16:54:13 | Re: remaining sql/json patches |
| Previous Message | Gurjeet Singh | 2023-07-13 16:38:03 | Re: MERGE ... RETURNING |