| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: display hot standby state in psql prompt |
| Date: | 2025-10-27 08:08:17 |
| Message-ID: | bc9be152-ca08-41f1-800f-d78fd38c75cb@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27/10/2025 04:32, Fujii Masao wrote:
> I think the "hs &&" and "ro &&" checks are no longer needed,
> since we've already confirmed they're not NULL at that point.
Right. Checks removed.
> Also, should "unknown" be marked for translation, as in the \conninfo code?
> I'm not sure whether showing a translated string in the psql prompt is
> desirable, though.
Here I am not sure if it's applicable. In this file there are other
strings that are not marked for translation, "abort", "on", "off". I
changed the string to _("unknown") for now, but we can remove it in
further iterations if we agree it's not desirable :)
v5 attached.
Thanks for the review.
Best, Jim
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-i-prompt-escape-to-indicate-server-read-only-.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-10-27 08:20:37 | COPY WHERE clause generated/system column reference |
| Previous Message | Jakub Wartak | 2025-10-27 08:06:53 | Re: [PATCH] Add Windows support for backtrace_functions (MSVC only) |