Re: Performing partition pruning using row value

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: "kato-sho(at)fujitsu(dot)com" <kato-sho(at)fujitsu(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Performing partition pruning using row value
Date: 2021-02-16 14:07:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 21.07.2020 11:24, kato-sho(at)fujitsu(dot)com wrote:
>> So, after looking at these functions and modifying this patch, I would like to add this patch to the next
> I updated this patch and registered for the next CF .
> regards,
> sho kato

Thank you for working on this improvement. I took a look at the code.

1) This piece of code is unneeded:

            switch (get_op_opfamily_strategy(opno, partopfamily))
                case BTLessStrategyNumber:
                case BTLessEqualStrategyNumber:
                case BTGreaterEqualStrategyNumber:
                case BTGreaterStrategyNumber:

See the comment for RowCompareExpr, which states that "A RowCompareExpr
node is only generated for the < <= > >= cases".

2) It's worth to add a regression test for this feature.

Other than that, the patch looks good to me.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-02-16 14:20:35 Re: [HACKERS] Custom compression methods
Previous Message Andy Fan 2021-02-16 14:03:46 Re: Keep notnullattrs in RelOptInfo (Was part of UniqueKey patch series)