On 11/02/2026 10:43, Anthonin Bonnefoy wrote:
> XLogReadRecord may already have consumed errormsg_deferred and set
> errormsg. We can't set it to NULL, or that would erase a valid error
Indeed. Should we place this initialisation at the top of
XLogFindNextRecord, before any processing? At that point, there's
nothing to erase.
> + /*
> + * we may have reported errors due to invalid WAL header, propagate the
> + * error message to the caller.
> + */
You can consider capitalising.
--
Thanks,
Mircea Cadariu