| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: handling of heap rewrites in logical decoding |
| Date: | 2018-03-21 13:20:37 |
| Message-ID: | bbe2a52b-08ea-c55e-5888-f378618f5e38@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/18 03:08, Craig Ringer wrote:
> Why was relrewrite / Anum_pg_class_relrewrite inserted at position 28,
> not appended to pg_class?
>
> I don't see how it'd cause any harm, I'm just curious about the rationale.
Adding it at the end would not be appropriate, since those are
variable-length fields. So I added it close to other fields of similar
purpose.
> Otherwise, I'm totally happy with what I see here. It's always nice to
> get to the end of a patch and think "wait, that's all?"
>
> Ready to go.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-03-21 13:28:24 | Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types |
| Previous Message | Jaime Soler | 2018-03-21 13:18:56 | Re: Hash join in SELECT target list expression keeps consuming memory |