Re: PATCH: Make pg_stop_backup() archive wait optional

From: David Steele <david(at)pgmasters(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: 2017-04-04 16:23:25
Message-ID: bbb04860-8c43-46f8-d528-3c2d270c84ba@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 4/4/17 11:42 AM, Stephen Frost wrote:
> * David Steele (david(at)pgmasters(dot)net) wrote:
>> On 3/22/17 4:42 PM, Peter Eisentraut wrote:
>>> On 3/22/17 15:14, Stephen Frost wrote:
>>>>> -SELECT * FROM pg_stop_backup(false);
>>>>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>>>>
>>>>> I think that it's better to get rid of "[" and "]" from the above because
>>>>> IMO this should be the command example that users actually can run.
>>>> Using the '[' and ']' are how all of the optional arguments are
>>>> specified in the documentation, see things like current_setting() in our
>>>> existing documentation:
>>>
>>> In the synopsis, but not in concrete examples.
>>
>> Wasn't quite sure what the protocol was in this case, and figured it
>> was easier to subtract than to add.
>
> Forgot to close this out sooner, apologies.
>
> This has been committed now.

Thank you, Stephen!

--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-04-04 16:43:23 Re: Instead of DROP function use UPDATE pg_proc in an upgrade extension script
Previous Message Maksim Milyutin 2017-04-04 16:10:37 Re: Proposal: Local indexes for partitioned table