Re: PATCH: Make pg_stop_backup() archive wait optional

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: 2017-04-04 15:42:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

* David Steele (david(at)pgmasters(dot)net) wrote:
> On 3/22/17 4:42 PM, Peter Eisentraut wrote:
> >On 3/22/17 15:14, Stephen Frost wrote:
> >>>-SELECT * FROM pg_stop_backup(false);
> >>>+SELECT * FROM pg_stop_backup(false [, true ]);
> >>>
> >>>I think that it's better to get rid of "[" and "]" from the above because
> >>>IMO this should be the command example that users actually can run.
> >>Using the '[' and ']' are how all of the optional arguments are
> >>specified in the documentation, see things like current_setting() in our
> >>existing documentation:
> >
> >In the synopsis, but not in concrete examples.
> Wasn't quite sure what the protocol was in this case, and figured it
> was easier to subtract than to add.

Forgot to close this out sooner, apologies.

This has been committed now.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2017-04-04 15:55:14 Re: postgres_fdw: support parameterized foreign joins
Previous Message Stephen Frost 2017-04-04 15:39:00 Re: [PATCH] Reduce src/test/recovery verbosity