| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: allow online change primary_conninfo |
| Date: | 2019-03-25 08:32:21 |
| Message-ID: | bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
On 3/4/19 7:19 AM, Michael Paquier wrote:
> On Sat, Mar 02, 2019 at 01:49:51PM +0300, Sergei Kornilov wrote:
>> This might be not the right way, but I can't think of a better way
>> to not switch to a different method than split of lastSourceFailed
>> processing and starting new source. Something like refactoring in
>> first attached patch. I move RequestXLogStreaming logic from
>> lastSourceFailed processing and add new pendingRestartSource
>> indicator.
>
> OK. This needs a rather close lookup, and I am not actually sure that
> you even need pendingRestartSource. Please let me a couple of days
> before coming back to you on 0001.
>
>> Second patch is mostly the same as previous version but uses new
>> pendingRestartSource mechanism instead of lastSourceFailed.
>
> This, on the other hand, looks like the implementation we are looking
> for based on the discussions which happened until now to have the
> startup process handle the shutdown and restart of the WAL receiver.
Do you know when you'll have a chance to revisit this?
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2019-03-25 08:39:01 | Re: Re: [PATCH][PROPOSAL] Add enum releation option type |
| Previous Message | David Steele | 2019-03-25 08:26:28 | Re: Re: Copy function for logical replication slots |