| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility. |
| Date: | 2019-02-16 10:14:21 |
| Message-ID: | ba819888-63c6-7f98-6acb-3731142d9414@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-11-21 01:07, Andres Freund wrote:
> Remove WITH OIDS support, change oid catalog column visibility.
I think you may have accidentally duplicated a line in this patch:
@@ -1602,20 +1602,9 @@ ExecFetchSlotHeapTupleDatum(TupleTableSlot *slot)
void
ExecInitResultTypeTL(PlanState *planstate)
{
- bool hasoid;
- TupleDesc tupDesc;
-
- if (ExecContextForcesOids(planstate, &hasoid))
- {
- /* context forces OID choice; hasoid is now set correctly */
- }
- else
- {
- /* given free choice, don't leave space for OIDs in result tuples */
- hasoid = false;
- }
+ TupleDesc tupDesc = ExecTypeFromTL(planstate->plan->targetlist);
- tupDesc = ExecTypeFromTL(planstate->plan->targetlist, hasoid);
+ tupDesc = ExecTypeFromTL(planstate->plan->targetlist);
planstate->ps_ResultTupleDesc = tupDesc;
}
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-02-16 15:24:05 | pgsql: Fix previous MinGW fix. |
| Previous Message | Michael Meskes | 2019-02-16 10:10:27 | pgsql: Add DECLARE STATEMENT support to ECPG. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ramanarayana | 2019-02-16 11:49:08 | Re: libpq host/hostaddr/conninfo inconsistencies |
| Previous Message | Thomas Munro | 2019-02-16 09:56:23 | Re: DNS SRV support for LDAP authentication |