Re: remove separate postgres.(sh)description files

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove separate postgres.(sh)description files
Date: 2020-01-08 12:33:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 31/12/2019 02:08, John Naylor wrote:
> I'm guessing the initial data for pg_(sh)description is output into
> separate files because it was too difficult for the traditional shell
> script to maintain enough state to do otherwise.

Yeah, I guess so. The roots of postgres.description goes all the way
back to 1997, when not only genbki was a shell script, but also initdb.

> With Perl, it's just as easy to assemble the data into the same
> format as the rest of the catalogs and then let the generic code path
> output it into postgres.bki. The attached patch does that and
> simplifies the catalog makefile and initdb.c.
Nice cleanup! Looks like we didn't have any mention of the
postgres.(sh)decription files in the docs, so no doc updates needed.
Grepping around, there are a few stray references to
postgres.description still:

$ git grep -r -I postgres.shdescript .
src/backend/catalog/Makefile:# postgres.bki, postgres.description,
src/tools/msvc/clean.bat:if %DIST%==1 if exist
src\backend\catalog\postgres.shdescription del /q

Barring objections, I'll remove those too, and commit this.

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2020-01-08 12:36:52 Re: Fastpath while arranging the changes in LSN order in logical decoding
Previous Message Fabien COELHO 2020-01-08 12:07:41 Re: pgbench - use pg logging capabilities