| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Cc: | 'Amit Langote' <amitlangote09(at)gmail(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-01-19 02:35:42 |
| Message-ID: | ba58f299-d50b-f347-4a0f-778cb6ac5588@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/19/21 2:28 AM, tsunakawa(dot)takay(at)fujitsu(dot)com wrote:
> From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
>> I took a look at this - there's a bit of bitrot due to
>> 708d165ddb92c, so attached is a rebased patch (0001) fixing that.
>>
>> 0002 adds a couple comments and minor tweaks
>>
>> 0003 addresses a couple shortcomings related to explain - we
>> haven't been showing the batch size for EXPLAIN (VERBOSE), because
>> there'd be no FdwState, so this tries to fix that. Furthermore,
>> there were no tests for EXPLAIN output with batch size, so I added
>> a couple.
>
> Thank you, good additions. They all look good. Only one point: I
> think the code for retrieving batch_size in create_foreign_modify()
> can be replaced with a call to the new function in 0003.
>
OK. Can you prepare a final patch, squashing all the commits into a
single one, and perhaps use the function in create_foreign_modify?
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2021-01-19 02:37:30 | RE: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Amit Kapila | 2021-01-19 02:31:07 | Re: pgindent for worker.c |