Re: allow_system_table_mods and DROP RULE

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow_system_table_mods and DROP RULE
Date: 2019-12-20 07:33:21
Message-ID: b994b23d-ae32-8b77-ff2d-c56dfa13260e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-12-18 16:53, Robert Haas wrote:
> On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> As a curious omission, DROP RULE does not check allow_system_table_mods.
>> Creating and renaming a rule does, and also creating, renaming, and
>> dropping a trigger does. The impact of this is probably nil in
>> practice, but for consistency we should probably add that. The patch is
>> pretty simple.
>
> +1. LGTM.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2019-12-20 08:10:58 Re: Implementing Incremental View Maintenance
Previous Message Marco Slot 2019-12-20 07:23:10 Re: Disallow cancellation of waiting for synchronous replication