Re: ANALYZE command progress checker

From: vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, David Fetter <david(at)fetter(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ANALYZE command progress checker
Date: 2017-03-22 09:11:58
Message-ID: b90e8e6a-c74c-cbed-a6b7-75a2ee54574b@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


On 2017/03/21 21:25, Haribabu Kommi wrote:
>
>
> On Tue, Mar 21, 2017 at 3:41 PM, vinayak
> <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp
> <mailto:Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>> wrote:
>
> Thank you for testing the patch on Windows platform.
>
>
> Thanks for the updated patch.
>
> It works good for a normal relation. But for a relation that contains
> child tables,
> the PROGRESS_ANALYZE_NUM_ROWS_SAMPLED produces wrong results.
>
Thank you for reviewing the patch.
The attached patch implements a way to report sample rows count from
acquire_sample_rows() even if called for child tables.
> How about adding another phase called
> PROGRESS_ANALYZE_PHASE_COLLECT_INHERIT_SAMPLE_ROWS
> and set this phase only when it is an inheritance analyze operation.
> And adding
> some explanation of ROWS_SAMPLED phase about inheritance tables
> how these sampled rows are calculated will provide good analyze
> progress of
> relation that contains child relations also.
I have added the phase called
PROGRESS_ANALYZE_PHASE_COLLECT_INH_SAMPLE_ROWS.
I have also updated the documentation.

The ANALYZE command takes long time in computing statistics phase.So I
think we can add some column or phase so that user can easily understand
the progress.
How about adding new column like "num_rows_processed" will compute the
statistics of specified column?
How about separate the computing "inheritance statistics" phase from the
computing regular "single table" statistics.
Comment?

Regards,
Vinayak Pokale
NTT Open Source Software Center

Attachment Content-Type Size
pg_stat_progress_analyze_v5.patch binary/octet-stream 19.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Beena Emerson 2017-03-22 09:44:02 Re: increasing the default WAL segment size
Previous Message Ideriha, Takeshi 2017-03-22 08:57:15 Re: [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG