| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "David Rowley" <dgrowleyml(at)gmail(dot)com>, "Erik Wienhold" <ewie(at)ewie(dot)name> |
| Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Use uppercase keywords in foreign key tutorial |
| Date: | 2025-10-24 13:40:18 |
| Message-ID: | b8d76840-5927-40aa-b38e-8ccb685aea92@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote:
> I'm not so sure about the "Should be pushed to all stable branches"
> part as it seems more of a general improvement than fixing a mistake.
> I imagine there will be varying opinions on that, however.
>
I also classify this as an improvement. No need to backpatch. I would apply
changes to back branches if the query is wrong; that's not the case.
I checked v2 and it looks good to me.
Since you are changing the query format, we have a mix of
CREATE TABLE foo(a int);
CREATE TABLE foo (a int);
The latter reads better for me. The same logic applies to VALUES. There is a
mix of space or non-space before parenthesis. Consistency is a good goal.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-10-24 15:36:14 | Re: Use uppercase keywords in foreign key tutorial |
| Previous Message | David Rowley | 2025-10-23 22:50:19 | Re: Use uppercase keywords in foreign key tutorial |