Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Stuart <sfbarbee(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints
Date: 2018-12-17 02:20:14
Message-ID: b7ffd062-cd82-c72d-6227-527bb9f42431@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2018/12/17 11:06, Michael Paquier wrote:
> On Mon, Dec 17, 2018 at 10:51:10AM +0900, Michael Paquier wrote:
>> Done just a few moments ago. I have also added a test with a primary
>> key rename which does not matter as long as LIKE INCLUDE INDEXES is
>> involved but that felt safer in the long-run.
>
> Buildfarm member prion is complaining on that:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2018-12-17%2001%3A46%3A36
> This uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE.
>
> It seems that the call to relation_close should happen after
> CacheInvalidateRelcache. Damn..

What a blunder! Sorry. :(

Thanks,
Amit

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-12-17 03:52:17 Re: Errors creating partitioned tables from existing using (LIKE <table>) after renaming table constraints
Previous Message Amit Langote 2018-12-17 02:18:14 Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction