Re: speeding up planning with partitions

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: speeding up planning with partitions
Date: 2019-01-17 02:17:45
Message-ID: b6e39c7a-7dc6-5e98-94aa-22b30688e50e@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2019/01/17 4:32, Alvaro Herrera wrote:
> On 2019-Jan-11, Amit Langote wrote:
>
>> Looking around a bit more, I started thinking even build_child_join_sjinfo
>> doesn't belong in appendinfo.c (just to be clear, it was defined in
>> prepunion.c before this commit), so maybe we should move it to joinrels.c
>> and instead export adjust_child_relids that's required by it from
>> appendinfo.c. There's already adjust_child_relids_multilevel in
>> appendinfo.h, so having adjust_child_relids next to it isn't too bad. At
>> least not as bad as appendinfo.c exporting build_child_join_sjinfo for
>> joinrels.c to use.
>
> OK, pushed, thanks.

Thank you.

> I may have caused merge conflicts with the rest of
> the series, because I reordered some functions -- sorry about that.

No problem.

I have rebased the patches. Other than rebasing, I've squashed the patch
to add inh_root_parent field to RelOptInfo which contained no other code
changes to use that field into the patch that contains changes to start
using it. Updated the commit message of lazy-partition-initialization
patch to be accurate (it contained old details that have changed since I
first wrote that commit message).

Thanks,
Amit

Attachment Content-Type Size
v15-0001-Overhaul-inheritance-update-delete-planning.patch text/plain 75.0 KB
v15-0002-Lazy-creation-of-RTEs-for-inheritance-children.patch text/plain 97.8 KB
v15-0003-Teach-planner-to-only-process-unpruned-partition.patch text/plain 6.8 KB
v15-0004-Do-not-lock-all-partitions-at-the-beginning.patch text/plain 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2019-01-17 02:48:31 Re: parseCheckAggregates vs. assign_query_collations
Previous Message Andrew Gierth 2019-01-17 02:12:50 Re: draft patch for strtof()