Re: pg_upgrade test writes to source directory

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade test writes to source directory
Date: 2022-05-26 14:36:47
Message-ID: b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25.05.22 09:25, Michael Paquier wrote:
>> It looks like an addition of
>>
>> chdir $ENV{TESTOUTDIR};
>>
>> could fix it. Please check the patch.
> I think that you mean TESTDIR, and not TESTOUTDIR?

I chose TESTOUTDIR because it corresponds to the tmp_check directory, so
that the output files of the pg_upgrade run are removed when the test
artifacts are cleaned up. When using TESTDIR, the pg_upgrade output
files end up in the build directory, which is less bad than the source
directory, but still not ideal.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2022-05-26 15:24:05 ICU_LOCALE set database default icu collation but not working as intended.
Previous Message Imseih (AWS), Sami 2022-05-26 13:41:09 Re: Add index scan progress to pg_stat_progress_vacuum