| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Exclude unlogged tables from base backups |
| Date: | 2018-01-30 01:44:16 |
| Message-ID: | b62e2983-1314-0027-d12e-c417a3e53002@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/29/18 8:10 PM, Masahiko Sawada wrote:
> On Tue, Jan 30, 2018 at 5:45 AM, Adam Brightwell
> <adam(dot)brightwell(at)crunchydata(dot)com> wrote:
>> On Mon, Jan 29, 2018 at 1:17 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>>>
>>> Whoops, my bad. Temp relations are stored in the db directories with a
>>> "t" prefix. Looks like we can take care of those easily enough but I
>>> think it should be a separate patch.
>>>
>>> I'll plan to submit that for CF 2018-03.
>
> +1
>
>>
>> I agree, I believe this should be a separate patch.
>>
>> As for the latest patch above, I have reviewed, applied and tested it.
>>
>> It looks good to me. As well, it applies cleanly against master at
>> (97d4445a03). All tests passed when running 'check-world'.
>>
>> If it is agreed that the temp file exclusion should be submitted as a
>> separate patch, then I will mark 'ready for committer'.
>
> Agreed, please mark this patch as "Ready for Committer".
I marked it just in case some enterprising committer from another time
zone swoops in and picks it up. Fingers crossed!
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2018-01-30 02:03:00 | Re: JIT compiling with LLVM v9.1 |
| Previous Message | David G. Johnston | 2018-01-30 01:14:54 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |