| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] hs_standby_disallowed test fix |
| Date: | 2020-05-18 14:23:23 |
| Message-ID: | b5d08ea2-8612-9b98-eb43-1e58631b009d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-05-12 19:35, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> I just wonder why standbycheck regression test doesn't run by default
>> in buildfarm. Which caused us not to notice this issue long time. Maybe
>> because it's difficult to set up hot-standby environment in the
>> regression test? If so, we might need to merge standbycheck test into
>> TAP tests for recovery.
>
> It seems likely to me that the standbycheck stuff has been completely
> obsoleted by the TAP-based recovery tests. We should get rid of it,
> after adding any missing coverage to the TAP tests.
I have looked into this a few times. It should definitely be done, but
there is actually a fair amount of coverage in the standbycheck that is
not in a TAP test, so it would be a fair amount of careful leg work to
get this all moved over.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2020-05-18 14:41:23 | Missing grammar production for WITH TIES |
| Previous Message | Bruce Momjian | 2020-05-18 14:20:16 | Re: PG 13 release notes, first draft |