|From:||Andrew Dunstan <andrew(at)dunslane(dot)net>|
|To:||Israel Barth Rubio <barthisrael(at)gmail(dot)com>|
|Subject:||Re: Add support for DEFAULT specification in COPY FROM|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2022-08-17 We 17:12, Israel Barth Rubio wrote:
> Hello Andrew,
> Thanks for reviewing this patch
> I am attaching the new patch, containing the above test in the regress
Thanks, this looks good but there are some things that need attention:
. There needs to be a check that this is being used with COPY FROM, and
the restriction needs to be stated in the docs and tested for. c.f.
. There needs to be support for this in psql's tab_complete.c, and
appropriate tests added
. There needs to be support for it in contrib/file_fdw/file_fdw.c, and a
. The tests should include psql's \copy as well as sql COPY
. I'm not sure we need a separate regression test file for this.
Probably these tests can go at the end of src/test/regress/sql/copy2.sql.
|Next Message||Tom Lane||2022-09-14 22:41:56||Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages|
|Previous Message||Nathan Bossart||2022-09-14 22:27:36||Re: archive modules|