Re: Update comments in nodeModifyTable.c

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Update comments in nodeModifyTable.c
Date: 2017-08-03 09:55:21
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017/08/02 4:07, Robert Haas wrote:
> On Tue, Aug 1, 2017 at 12:31 AM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Maybe I'm missing something, but I'm not sure that's a good idea because the
>> change says like we might have 'wholerow' only for the FDW case, but that
>> isn't correct because we would have 'wholerow' for a view as well. ISTM that
>> views should be one of the typical cases, so I'd like to propose to modify
>> the sentence starting with 'Typically' to something like this: "Typically,
>> this will be a 'ctid' or 'wholerow' attribute, but in the case of a foreign
>> data wrapper it might be a set of junk attributes sufficient to identify the
>> remote row." What do you think about that?
> Works for me.

I updated the patch that way. Attached is a new version of the patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
nodeModifyTable-comment-update-v3.patch text/plain 1.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2017-08-03 10:02:59 Support for Secure Transport SSL library on macOS as OpenSSL alternative
Previous Message Fabien COELHO 2017-08-03 09:39:52 Re: pgbench: Skipping the creating primary keys after initialization