| From: | "Neil Conway" <neilc(at)samurai(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Remove inappropriate memory context switch in |
| Date: | 2008-11-30 21:26:17 |
| Message-ID: | b4e5ce320811301326s4ffca1bdhdf29520f3efd340c@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Nov 30, 2008 at 1:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Hm, too bad you didn't respond to my message inquiring about this a
> couple days ago.
My apologies -- my mail filters were overeager, and I didn't see it.
> I'll take a look in a bit. However, the switch in the shutdown function
> was simply wrong, because it was *not* "returning to the caller's
> context". I suspect what this really says is dblink is doing something
> it shouldn't.
Well, dblink is simply calling SRF_RETURN_DONE() when the current
context is the multi-call memory context. We could outlaw that
practice, but that risks breaking out-of-tree SRFs that do something
similar. I think better would be to figure out a more appropriate
memory context to switch into before deleting the multi-call context.
Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-11-30 21:29:03 | Re: pgsql: Remove inappropriate memory context switch in |
| Previous Message | Tom Lane | 2008-11-30 21:09:18 | Re: pgsql: Remove inappropriate memory context switch in |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-11-30 21:29:03 | Re: pgsql: Remove inappropriate memory context switch in |
| Previous Message | David Rowley | 2008-11-30 21:19:12 | Re: Windowing Function Patch Review -> Standard Conformance |